Replace all hardcoded "midi::" namespace by "MIDI_NAMESPACE::" - #321
Open
YaelBx wants to merge 1 commit into
Open
Replace all hardcoded "midi::" namespace by "MIDI_NAMESPACE::"#321YaelBx wants to merge 1 commit into
YaelBx wants to merge 1 commit into
Conversation
Signed-off-by: Yaël Boutreux <yael.boutreux@gmail.com>
Author
@franky47 reminder, I did not managed to execute unit-test on my setup, can you ACK me that you did run them and all good? |
Member
|
They are running in the CI on GitHub actions, let's wait and see 👀. |
Member
|
The error I see comes from Google Test itself, I'll have to investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real issue is the hardcoded one in src/midi_Message.h when trying to edit the default "midi" namespace.
IMHO, if we can use custom namespace, no midi:: namespace should be hardcoded, we should instead always use the MIDI_NAMESPACE MACRO.
I did not managed to install the unit-test to verify my modifications, too much issues with Visual and /W argument.
If someone with a working unit-test config can verify the modifications, this would be lovely.